From 5b522e30986da0c333b2f112b9011ffae36ab99c Mon Sep 17 00:00:00 2001 From: Vortrex <3858226+VortrexFTW@users.noreply.github.com> Date: Sun, 18 Dec 2022 15:22:59 -0600 Subject: [PATCH] Show error if geoip cmd fails --- scripts/server/staff.js | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/scripts/server/staff.js b/scripts/server/staff.js index c5d56034..25391369 100644 --- a/scripts/server/staff.js +++ b/scripts/server/staff.js @@ -295,9 +295,19 @@ function getPlayerGeoIPInformationCommand(command, params, client) { return false; } - let countryName = module.geoip.getCountryName(getGlobalConfig().geoIPCountryDatabaseFilePath, getPlayerIP(targetClient)); - let subDivisionName = module.geoip.getSubdivisionName(getGlobalConfig().geoIPCityDatabaseFilePath, getPlayerIP(targetClient)); - let cityName = module.geoip.getCityName(getGlobalConfig().geoIPCityDatabaseFilePath, getPlayerIP(targetClient)); + let countryName = "Unknown"; + let subDivisionName = "Unknown"; + let cityName = "Unknown"; + + try { + countryName = module.geoip.getCountryName(getGlobalConfig().geoIPCountryDatabaseFilePath, getPlayerIP(targetClient)); + subDivisionName = module.geoip.getSubdivisionName(getGlobalConfig().geoIPCityDatabaseFilePath, getPlayerIP(targetClient)); + cityName = module.geoip.getCityName(getGlobalConfig().geoIPCityDatabaseFilePath, getPlayerIP(targetClient)); + } catch (err) { + messagePlayerError(client, `There was an error getting the geoip information for ${getPlayerName(targetClient)}`); + submitBugReport(client, `[AUTOMATED REPORT] Getting geoip information for ${getPlayerName(targetClient)} (${getPlayerIP(targetClient)} failed: ${err}`); + return false; + } messagePlayerInfo(client, `{ALTCOLOUR}${getPlayerName(targetClient)}{MAINCOLOUR} is from {ALTCOLOUR}${cityName}, ${subDivisionName}, ${countryName}`); }