Remove close button from menu

This commit is contained in:
vfsfitvnm
2022-07-09 16:13:35 +02:00
parent 29025da7e9
commit 32aeadf87d
7 changed files with 9 additions and 45 deletions

View File

@@ -18,17 +18,18 @@ import it.vfsfitvnm.route.RouteHandler
import it.vfsfitvnm.route.empty import it.vfsfitvnm.route.empty
import it.vfsfitvnm.vimusic.* import it.vfsfitvnm.vimusic.*
import it.vfsfitvnm.vimusic.R import it.vfsfitvnm.vimusic.R
import it.vfsfitvnm.vimusic.models.DetailedSong
import it.vfsfitvnm.vimusic.models.Playlist import it.vfsfitvnm.vimusic.models.Playlist
import it.vfsfitvnm.vimusic.models.SongPlaylistMap import it.vfsfitvnm.vimusic.models.SongPlaylistMap
import it.vfsfitvnm.vimusic.models.DetailedSong
import it.vfsfitvnm.vimusic.ui.components.LocalMenuState import it.vfsfitvnm.vimusic.ui.components.LocalMenuState
import it.vfsfitvnm.vimusic.ui.screens.rememberAlbumRoute
import it.vfsfitvnm.vimusic.ui.screens.rememberArtistRoute import it.vfsfitvnm.vimusic.ui.screens.rememberArtistRoute
import it.vfsfitvnm.vimusic.ui.screens.rememberCreatePlaylistRoute import it.vfsfitvnm.vimusic.ui.screens.rememberCreatePlaylistRoute
import it.vfsfitvnm.vimusic.ui.screens.rememberAlbumRoute
import it.vfsfitvnm.vimusic.utils.* import it.vfsfitvnm.vimusic.utils.*
import it.vfsfitvnm.youtubemusic.models.NavigationEndpoint import it.vfsfitvnm.youtubemusic.models.NavigationEndpoint
import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.Dispatchers
@ExperimentalAnimationApi @ExperimentalAnimationApi
@Composable @Composable
fun InFavoritesMediaItemMenu( fun InFavoritesMediaItemMenu(
@@ -344,8 +345,6 @@ fun MediaItemMenu(
detectTapGestures { } detectTapGestures { }
} }
) { ) {
MenuCloseButton(onClick = onDismiss)
onStartRadio?.let { onStartRadio -> onStartRadio?.let { onStartRadio ->
MenuEntry( MenuEntry(
icon = R.drawable.radio, icon = R.drawable.radio,

View File

@@ -20,7 +20,7 @@ import it.vfsfitvnm.vimusic.ui.styling.LocalColorPalette
import it.vfsfitvnm.vimusic.ui.styling.LocalTypography import it.vfsfitvnm.vimusic.ui.styling.LocalTypography
import it.vfsfitvnm.vimusic.utils.medium import it.vfsfitvnm.vimusic.utils.medium
import it.vfsfitvnm.vimusic.utils.secondary import it.vfsfitvnm.vimusic.utils.secondary
import it.vfsfitvnm.vimusic.utils.semiBold
@Composable @Composable
inline fun Menu( inline fun Menu(
@@ -31,30 +31,19 @@ inline fun Menu(
Column( Column(
modifier = modifier modifier = modifier
.padding(top = 48.dp)
.verticalScroll(rememberScrollState()) .verticalScroll(rememberScrollState())
.fillMaxWidth() .fillMaxWidth()
.background( .background(
color = colorPalette.elevatedBackground, color = colorPalette.elevatedBackground,
shape = RoundedCornerShape(topStart = 12.dp, topEnd = 12.dp) shape = RoundedCornerShape(topStart = 16.dp, topEnd = 16.dp)
) )
.padding(top = 8.dp)
.padding(vertical = 8.dp), .padding(vertical = 8.dp),
content = content content = content
) )
} }
@Composable
inline fun BasicMenu(
noinline onDismiss: () -> Unit,
modifier: Modifier = Modifier,
content: @Composable ColumnScope.() -> Unit
) {
Menu(modifier = modifier) {
MenuCloseButton(onClick = onDismiss)
content()
}
}
@Composable @Composable
fun MenuEntry( fun MenuEntry(
@DrawableRes icon: Int, @DrawableRes icon: Int,
@@ -114,7 +103,7 @@ fun MenuIconButton(
Box( Box(
modifier = modifier modifier = modifier
.padding(horizontal = 12.dp) .padding(horizontal = 14.dp)
) { ) {
Image( Image(
painter = painterResource(icon), painter = painterResource(icon),
@@ -122,24 +111,12 @@ fun MenuIconButton(
colorFilter = ColorFilter.tint(colorPalette.text), colorFilter = ColorFilter.tint(colorPalette.text),
modifier = Modifier modifier = Modifier
.clickable(onClick = onClick) .clickable(onClick = onClick)
.padding(horizontal = 8.dp, vertical = 16.dp) .padding(horizontal = 8.dp, vertical = 8.dp)
.size(20.dp) .size(20.dp)
) )
} }
} }
@Composable
fun MenuCloseButton(
onClick: () -> Unit,
modifier: Modifier = Modifier
) {
MenuIconButton(
icon = R.drawable.close,
onClick = onClick,
modifier = modifier
)
}
@Composable @Composable
fun MenuBackButton( fun MenuBackButton(
onClick: () -> Unit, onClick: () -> Unit,
@@ -151,5 +128,3 @@ fun MenuBackButton(
modifier = modifier modifier = modifier
) )
} }

View File

@@ -126,8 +126,6 @@ fun AlbumScreen(
.clickable { .clickable {
menuState.display { menuState.display {
Menu { Menu {
MenuCloseButton(onClick = menuState::hide)
MenuEntry( MenuEntry(
icon = R.drawable.enqueue, icon = R.drawable.enqueue,
text = "Enqueue", text = "Enqueue",

View File

@@ -114,8 +114,6 @@ fun BuiltInPlaylistScreen(
.clickable { .clickable {
menuState.display { menuState.display {
Menu { Menu {
MenuCloseButton(onClick = menuState::hide)
MenuEntry( MenuEntry(
icon = R.drawable.enqueue, icon = R.drawable.enqueue,
text = "Enqueue", text = "Enqueue",

View File

@@ -157,8 +157,6 @@ fun IntentUriScreen(uri: Uri) {
.clickable { .clickable {
menuState.display { menuState.display {
Menu { Menu {
MenuCloseButton(onClick = menuState::hide)
MenuEntry( MenuEntry(
icon = R.drawable.enqueue, icon = R.drawable.enqueue,
text = "Enqueue", text = "Enqueue",

View File

@@ -148,8 +148,6 @@ fun LocalPlaylistScreen(
.clickable { .clickable {
menuState.display { menuState.display {
Menu { Menu {
MenuCloseButton(onClick = menuState::hide)
MenuEntry( MenuEntry(
icon = R.drawable.enqueue, icon = R.drawable.enqueue,
text = "Enqueue", text = "Enqueue",

View File

@@ -121,8 +121,6 @@ fun PlaylistScreen(
.clickable { .clickable {
menuState.display { menuState.display {
Menu { Menu {
MenuCloseButton(onClick = menuState::hide)
MenuEntry( MenuEntry(
icon = R.drawable.enqueue, icon = R.drawable.enqueue,
text = "Enqueue", text = "Enqueue",