From 73cc0554c2f600cf4ceb592989bcab254baaf4c4 Mon Sep 17 00:00:00 2001 From: vfsfitvnm Date: Wed, 27 Jul 2022 11:11:17 +0200 Subject: [PATCH] Add vertical padding to items in lists --- .../vfsfitvnm/vimusic/ui/screens/SearchResultScreen.kt | 10 +++++----- .../it/vfsfitvnm/vimusic/ui/styling/Dimensions.kt | 2 ++ .../kotlin/it/vfsfitvnm/vimusic/ui/views/SongItem.kt | 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/app/src/main/kotlin/it/vfsfitvnm/vimusic/ui/screens/SearchResultScreen.kt b/app/src/main/kotlin/it/vfsfitvnm/vimusic/ui/screens/SearchResultScreen.kt index b65b835..64fcf18 100644 --- a/app/src/main/kotlin/it/vfsfitvnm/vimusic/ui/screens/SearchResultScreen.kt +++ b/app/src/main/kotlin/it/vfsfitvnm/vimusic/ui/screens/SearchResultScreen.kt @@ -343,7 +343,7 @@ fun SmallItem( interactionSource = remember { MutableInteractionSource() }, onClick = onClick ) - .padding(vertical = 5.dp, horizontal = 16.dp) + .padding(vertical = Dimensions.itemsVerticalPadding, horizontal = 16.dp) ) is YouTube.Item.Song -> SmallSongItem( song = item, @@ -361,7 +361,7 @@ fun SmallItem( interactionSource = remember { MutableInteractionSource() }, onClick = onClick ) - .padding(vertical = 5.dp, horizontal = 16.dp) + .padding(vertical = Dimensions.itemsVerticalPadding, horizontal = 16.dp) ) is YouTube.Item.Video -> SmallVideoItem( video = item, @@ -379,7 +379,7 @@ fun SmallItem( interactionSource = remember { MutableInteractionSource() }, onClick = onClick ) - .padding(vertical = 5.dp, horizontal = 16.dp) + .padding(vertical = Dimensions.itemsVerticalPadding, horizontal = 16.dp) ) } } @@ -584,7 +584,7 @@ private fun LoadingOrError( modifier = Modifier .alpha(1f - index * 0.125f) .fillMaxWidth() - .padding(vertical = 5.dp, horizontal = 16.dp) + .padding(vertical = Dimensions.itemsVerticalPadding, horizontal = 16.dp) ) } else { SmallSongItemShimmer( @@ -592,7 +592,7 @@ private fun LoadingOrError( modifier = Modifier .alpha(1f - index * 0.125f) .fillMaxWidth() - .padding(vertical = 5.dp, horizontal = 16.dp) + .padding(vertical = Dimensions.itemsVerticalPadding, horizontal = 16.dp) ) } } diff --git a/app/src/main/kotlin/it/vfsfitvnm/vimusic/ui/styling/Dimensions.kt b/app/src/main/kotlin/it/vfsfitvnm/vimusic/ui/styling/Dimensions.kt index ebd56f8..37eae8b 100644 --- a/app/src/main/kotlin/it/vfsfitvnm/vimusic/ui/styling/Dimensions.kt +++ b/app/src/main/kotlin/it/vfsfitvnm/vimusic/ui/styling/Dimensions.kt @@ -8,6 +8,8 @@ import androidx.compose.ui.unit.dp @Suppress("ClassName") object Dimensions { + val itemsVerticalPadding = 8.dp + object thumbnails { val album = 128.dp val artist = 192.dp diff --git a/app/src/main/kotlin/it/vfsfitvnm/vimusic/ui/views/SongItem.kt b/app/src/main/kotlin/it/vfsfitvnm/vimusic/ui/views/SongItem.kt index 9837e68..437da05 100644 --- a/app/src/main/kotlin/it/vfsfitvnm/vimusic/ui/views/SongItem.kt +++ b/app/src/main/kotlin/it/vfsfitvnm/vimusic/ui/views/SongItem.kt @@ -170,7 +170,7 @@ fun SongItem( onClick = onClick ) .fillMaxWidth() - .padding(vertical = 5.dp) + .padding(vertical = Dimensions.itemsVerticalPadding) .background(backgroundColor ?: colorPalette.background) .padding(start = 16.dp, end = if (trailingContent == null) 16.dp else 8.dp) ) {