From 7f164d789875d2a1400ad7178f904cbaccd64ae4 Mon Sep 17 00:00:00 2001 From: vfsfitvnm Date: Sun, 5 Jun 2022 11:55:09 +0200 Subject: [PATCH] Throw PlaybackException instead of Error in PlayerService::createDataSourceFactory --- .../it/vfsfitvnm/vimusic/services/PlayerService.kt | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/app/src/main/kotlin/it/vfsfitvnm/vimusic/services/PlayerService.kt b/app/src/main/kotlin/it/vfsfitvnm/vimusic/services/PlayerService.kt index 30f0d3f..15f34c0 100644 --- a/app/src/main/kotlin/it/vfsfitvnm/vimusic/services/PlayerService.kt +++ b/app/src/main/kotlin/it/vfsfitvnm/vimusic/services/PlayerService.kt @@ -330,10 +330,17 @@ class PlayerService : MediaSessionService(), MediaSession.MediaItemFiller, dataSpec.withUri(url.value.toUri()) .subrange(dataSpec.uriPositionOffset, chunkLength) } - // TODO - is Outcome.Error.Network -> throw Error("no network") + is Outcome.Error.Network -> throw PlaybackException( + "Couldn't reach the internet", + null, + PlaybackException.ERROR_CODE_REMOTE_ERROR + ) is Outcome.Error.Unhandled -> throw url.throwable - else -> TODO("unreachable") + else -> throw PlaybackException( + "Unexpected error", + null, + PlaybackException.ERROR_CODE_REMOTE_ERROR + ) } } }