hamyack/GTA4RP
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimize vehicle rent check timer

Browse Source
This commit is contained in:
Vortrex
2021-10-02 16:50:02 -05:00
parent 2733197758
commit 438ea59adf
1 changed files with 25 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
scripts/server/timers.js
View File

@@ -112,6 +112,24 @@ function thirtyMinuteTimerFunction() {
// =========================================================================== // ===========================================================================
function vehicleRentCheck() { function vehicleRentCheck() {
// Loop through players, not vehicles. Much more efficient (and doesn't consume resources when no players are connected)
let clients = getClients();
for(let i in clients) {
if(getPlayerData(clients[i]) != false) {
if(isPlayerLoggedIn(clients[i] && isPlayerSpawned(clients[i]))) {
if(getPlayerData(clients[i]).rentingVehicle != false) {
if(getPlayerCurrentSubAccount(clients[i]).cash < getServerData().vehicles[getPlayerData(clients[i]).rentingVehicle].rentPrice) {
messagePlayerAlert(clients[i], `You do not have enough money to continue renting this vehicle!`);
stopRentingVehicle(clients[i]);
} else {
takePlayerCash(clients[i], getServerData().vehicles[getPlayerData(clients[i]).rentingVehicle].rentPrice);
}
}
}
}
}
/*
for(let i in getServerData().vehicles) { for(let i in getServerData().vehicles) {
if(getServerData().vehicles[i] != null) { if(getServerData().vehicles[i] != null) {
if(getServerData().vehicles[i].rentPrice > 0) { if(getServerData().vehicles[i].rentPrice > 0) {
@@ -129,6 +147,7 @@ function vehicleRentCheck() {
} }
} }
} }
*/
} }
// =========================================================================== // ===========================================================================
@@ -174,9 +193,12 @@ function checkPayDays() {
let clients = getClients(); let clients = getClients();
for(let i in clients) { for(let i in clients) {
if(isPlayerLoggedIn(clients[i]) && isPlayerSpawned(clients[i])) { if(isPlayerLoggedIn(clients[i]) && isPlayerSpawned(clients[i])) {
getPlayerData(clients[i]).payDayStart = sdl.ticks;
playerPayDay(clients[i]);
//if(sdl.ticks-getPlayerData(clients[i]).payDayTickStart >= getGlobalConfig().payDayTickCount) { //if(sdl.ticks-getPlayerData(clients[i]).payDayTickStart >= getGlobalConfig().payDayTickCount) {
getPlayerData(clients[i]).payDayStart = sdl.ticks; // getPlayerData(clients[i]).payDayStart = sdl.ticks;
playerPayDay(clients[i]); // playerPayDay(clients[i]);
//} //}
} }
} }
@@ -190,7 +212,7 @@ function showRandomTipToAllPlayers() {
let clients = getClients(); let clients = getClients();
for(let i in clients) { for(let i in clients) {
if(isPlayerLoggedIn(clients[i]) && isPlayerSpawned(clients[i])) { if(isPlayerLoggedIn(clients[i]) && isPlayerSpawned(clients[i])) {
messagePlayerTimedRandomTip(clients[i], randomTips[tipId]); messagePlayerTimedRandomTip(null, randomTips[tipId]);
} }
} }
} }